React to onUserDrivenAnimationEnded event in JS (#45414)#45839
Closed
cipolleschi wants to merge 1 commit into
Closed
React to onUserDrivenAnimationEnded event in JS (#45414)#45839cipolleschi wants to merge 1 commit into
cipolleschi wants to merge 1 commit into
Conversation
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D60499583 |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D60499583 |
cipolleschi
force-pushed
the
export-D60499583
branch
from
0eaa663 to
da24397
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D60499583 |
cipolleschi
force-pushed
the
export-D60499583
branch
from
da24397 to
0db021c
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D60499583 |
cipolleschi
force-pushed
the
export-D60499583
branch
from
0db021c to
1e61ae2
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D60499583 |
cipolleschi
force-pushed
the
export-D60499583
branch
from
1e61ae2 to
6ca1700
Compare
Summary: Pull Request resolved: facebook#45839 Pull Request resolved: facebook#45414 This change completes the fix for broken pressable when animations were applied to components with native driven animations. When creating the AnimatedProps, if they are natively drive animation, we look for the AnimatedValue involved and we register a listener. This is needed to make sure that the NativeModule will send te updated value upon calling the `update` function. Then, when observing the props lifecycle, it register a listener to the new `OnUserAnimationEnded` event, fired by the NativeAnimation module. When the `OnUserAnimationEnded` event is fired, the AnimatedProps will update the props that depends on the user driven animation. ## Changelog [General][Fixed] - reallign the shadow tree and the native tree when the user finishes interacting with the app. Reviewed By: sammy-SC Differential Revision: D60499583
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D60499583 |
cipolleschi
force-pushed
the
export-D60499583
branch
from
6ca1700 to
19bd7dc
Compare
Contributor
|
This pull request has been merged in a8786fc. |
Collaborator
|
This pull request was successfully merged by @cipolleschi in a8786fc When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
This change completes the fix for broken pressable when animations were applied to components with native driven animations.
When creating the AnimatedProps, if they are natively drive animation, we look for the AnimatedValue involved and we register a listener. This is needed to make sure that the NativeModule will send te updated value upon calling the
updatefunction.Then, when observing the props lifecycle, it register a listener to the new
OnUserAnimationEndedevent, fired by the NativeAnimation module.When the
OnUserAnimationEndedevent is fired, the AnimatedProps will update the props that depends on the user driven animation.Changelog
[General][Fixed] - reallign the shadow tree and the native tree when the user finishes interacting with the app.
Differential Revision: D60499583