Skip to content

chore: migrate GenerateCodegenArtifactsTaskTest to assertj #45845

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Tony-MK wants to merge 4 commits into from
Closed

chore: migrate GenerateCodegenArtifactsTaskTest to assertj #45845

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
aaf321e
chore: migrate GenerateCodegenArtifactsTaskTest to assertj
Tony-MK Jul 31, 2024
7736485
inverting...
Tony-MK Aug 1, 2024
56c15ae
commiting suggestion
Tony-MK Aug 1, 2024
16cb291
typos
Tony-MK Aug 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
45 changes: 20 additions & 25 deletions ...radle-plugin/src/test/kotlin/com/facebook/react/tasks/GenerateCodegenArtifactsTaskTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,7 @@ import com.facebook.react.tests.*
import com.facebook.react.tests.createProject
import com.facebook.react.tests.createTestTask
import java.io.File
import org.junit.Assert.assertEquals
import org.junit.Assert.assertTrue
import org.assertj.Assert.assertThat
import org.junit.Rule
import org.junit.Test
import org.junit.rules.TemporaryFolder
Expand All @@ -29,7 +28,7 @@ class GenerateCodegenArtifactsTaskTest {

val task = createTestTask<GenerateCodegenArtifactsTask> { it.generatedSrcDir.set(outputDir) }

assertEquals(File(outputDir, "schema.json"), task.generatedSchemaFile.get().asFile)
assertThat(task.generatedSchemaFile.get().asFile).isEqualTo(File(outputDir, "schema.json"))
}

@Test
Expand All @@ -38,8 +37,8 @@ class GenerateCodegenArtifactsTaskTest {

val task = createTestTask<GenerateCodegenArtifactsTask> { it.generatedSrcDir.set(outputDir) }

assertEquals(File(outputDir, "java"), task.generatedJavaFiles.get().asFile)
assertEquals(File(outputDir, "jni"), task.generatedJniFiles.get().asFile)
assertThat(task.generatedJavaFiles.get().asFile).isEqualTo(File(outputDir, "java"))
assertThat(task.generatedJniFiles.get().asFile).isEqualTo(File(outputDir, "jni"))
}

@Test
Expand All @@ -54,12 +53,12 @@ class GenerateCodegenArtifactsTaskTest {
it.packageJsonFile.set(packageJsonFile)
}

assertEquals(listOf("npm", "help"), task.nodeExecutableAndArgs.get())
assertEquals("com.example.test", task.codegenJavaPackageName.get())
assertEquals("example-test", task.libraryName.get())
assertTrue(task.inputs.properties.containsKey("nodeExecutableAndArgs"))
assertTrue(task.inputs.properties.containsKey("codegenJavaPackageName"))
assertTrue(task.inputs.properties.containsKey("libraryName"))
assertThat(task.nodeExecutableAndArgs.get()).isEqualTo(listOf("npm", "help"))
assertThat(task.codegenJavaPackageName.get()).isEqualTo("com.example.test")
assertThat(task.libraryName.get()).isEqualTo("example-test")
assertThat(task.inputs.properties).containsKeys(
"nodeExecutableAndArgs", "codegenJavaPackageName", "libraryName"
)
}

@Test
Expand All @@ -77,8 +76,7 @@ class GenerateCodegenArtifactsTaskTest {

task.setupCommandLine("example-test", "com.example.test")

assertEquals(
listOf(
assertThat(task.commandLine).containsExactly(
"--verbose",
File(reactNativeDir, "scripts/generate-specs-cli.js").toString(),
"--platform",
Expand All @@ -91,8 +89,7 @@ class GenerateCodegenArtifactsTaskTest {
"example-test",
"--javaPackageName",
"com.example.test",
),
task.commandLine.toMutableList())
)
}

@Test
Expand All @@ -111,8 +108,7 @@ class GenerateCodegenArtifactsTaskTest {

task.setupCommandLine("example-test", "com.example.test")

assertEquals(
listOf(
assertThat(task.commandLine).containsExactly(
"cmd",
"/c",
"--verbose",
Expand All @@ -129,8 +125,7 @@ class GenerateCodegenArtifactsTaskTest {
"example-test",
"--javaPackageName",
"com.example.test",
),
task.commandLine.toMutableList())
)
}

@Test
Expand Down Expand Up @@ -162,8 +157,8 @@ class GenerateCodegenArtifactsTaskTest {

val (libraryName, javaPackageName) = task.resolveTaskParameters()

assertEquals("an-awesome-library", libraryName)
assertEquals("com.awesome.package", javaPackageName)
assertThat(libraryName).isEqualTo("an-awesome-library")
assertThat(javaPackageName).isEqualTo("com.awesome.package")
}

@Test
Expand Down Expand Up @@ -191,8 +186,8 @@ class GenerateCodegenArtifactsTaskTest {

val (libraryName, javaPackageName) = task.resolveTaskParameters()

assertEquals("a-library-name-from-gradle", libraryName)
assertEquals("com.example.test", javaPackageName)
assertThat(libraryName).isEqualTo("a-library-name-from-gradle")
assertThat(javaPackageName).isEqualTo("com.example.test")
}

@Test
Expand All @@ -206,7 +201,7 @@ class GenerateCodegenArtifactsTaskTest {

val (libraryName, javaPackageName) = task.resolveTaskParameters()

assertEquals("a-library-name-from-gradle", libraryName)
assertEquals("com.example.test", javaPackageName)
assertThat(libraryName).isEqualTo("a-library-name-from-gradle")
assertThat(javaPackageName).isEqualTo("com.example.test")
}
}