Add asset dest path resolver override#45878
Closed
andrewdacenko wants to merge 1 commit into
Closed
Conversation
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D60447815 |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D60447815 |
andrewdacenko
force-pushed
the
export-D60447815
branch
from
90060cc to
b0a876d
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D60447815 |
andrewdacenko
force-pushed
the
export-D60447815
branch
from
b0a876d to
1d15437
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D60447815 |
andrewdacenko
force-pushed
the
export-D60447815
branch
from
1d15437 to
fb61351
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D60447815 |
andrewdacenko
force-pushed
the
export-D60447815
branch
from
fb61351 to
c82eeda
Compare
Summary: Pull Request resolved: facebook#45878 Changelog: [General][Added] - Add optional `PackagerAsset.resolver` prop so AssetSourceResolver can use it instead of `Platform.OS` to identify where asset is stored on device. Reviewed By: rshest Differential Revision: D60447815
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D60447815 |
andrewdacenko
force-pushed
the
export-D60447815
branch
from
c82eeda to
38362da
Compare
facebook-github-bot
pushed a commit
to facebook/buck2
that referenced
this pull request
Aug 7, 2024
Summary: X-link: facebook/react-native#45878 Changelog: [General][Added] - Add optional `PackagerAsset.resolver` prop so AssetSourceResolver can use it instead of `Platform.OS` to identify where asset is stored on device. Reviewed By: rshest Differential Revision: D60447815 fbshipit-source-id: 44fb8510746905ca0cd266144e213c40a3fa86a9
facebook-github-bot
pushed a commit
to facebook/buck2-prelude
that referenced
this pull request
Aug 7, 2024
Summary: X-link: facebook/react-native#45878 Changelog: [General][Added] - Add optional `PackagerAsset.resolver` prop so AssetSourceResolver can use it instead of `Platform.OS` to identify where asset is stored on device. Reviewed By: rshest Differential Revision: D60447815 fbshipit-source-id: 44fb8510746905ca0cd266144e213c40a3fa86a9
Contributor
|
This pull request has been merged in 3f3a85b. |
Collaborator
|
This pull request was successfully merged by @andrewdacenko in 3f3a85b When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog: [General]
Add optional
PackagerAsset.resolverprop so AssetSourceResolver can use it instead ofPlatform.OSto identify where asset is stored on device.Reviewed By: rshest
Differential Revision: D60447815