Skip to content

Mark setNetworkActivityIndicatorVisible as deprecated #45950

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ingridwang wants to merge 1 commit into from
Closed

Mark setNetworkActivityIndicatorVisible as deprecated #45950

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion packages/react-native/Libraries/Components/StatusBar/StatusBar.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -272,8 +272,10 @@ class StatusBar extends React.Component<Props> {
}

/**
* Control the visibility of the network activity indicator
* DEPRECATED - The status bar network activity indicator is not supported in iOS 13 and later. This will be removed in a future release.
* @param visible Show the indicator.
*
* @deprecated
*/
static setNetworkActivityIndicatorVisible(visible: boolean) {
if (Platform.OS !== 'ios') {
Expand Down
4 changes: 4 additions & 0 deletions packages/react-native/React/CoreModules/RCTStatusBarManager.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,7 +161,11 @@ - (void)applicationWillChangeStatusBarFrame:(NSNotification *)notification
RCT_EXPORT_METHOD(setNetworkActivityIndicatorVisible : (BOOL)visible)
{
dispatch_async(dispatch_get_main_queue(), ^{
#pragma clang diagnostic push
#pragma clang diagnostic ignored "-Wdeprecated-declarations"
// This is no longer supported in iOS 13 and later. We will remove this method in a future release.
RCTSharedApplication().networkActivityIndicatorVisible = visible;
#pragma clang diagnostic pop
});
}

Expand Down
63 changes: 0 additions & 63 deletions packages/rn-tester/js/examples/StatusBar/StatusBarExample.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,44 +149,6 @@ class StatusBarStyleExample extends React.Component<{...}, $FlowFixMeState> {
}
}

class StatusBarNetworkActivityExample extends React.Component<
{...},
$FlowFixMeState,
> {
state: $FlowFixMe | {networkActivityIndicatorVisible: boolean} = {
networkActivityIndicatorVisible: false,
};

_onChangeNetworkIndicatorVisible = () => {
this.setState({
networkActivityIndicatorVisible:
!this.state.networkActivityIndicatorVisible,
});
};

render(): React.Node {
return (
<View>
<StatusBar
networkActivityIndicatorVisible={
this.state.networkActivityIndicatorVisible
}
/>
<TouchableHighlight
style={styles.wrapper}
onPress={this._onChangeNetworkIndicatorVisible}>
<View style={styles.button}>
<Text>
networkActivityIndicatorVisible:
{this.state.networkActivityIndicatorVisible ? 'true' : 'false'}
</Text>
</View>
</TouchableHighlight>
</View>
);
}
}

class StatusBarBackgroundColorExample extends React.Component<
{...},
$FlowFixMeState,
Expand Down Expand Up @@ -308,24 +270,6 @@ class StatusBarStaticIOSExample extends React.Component<{...}> {
<Text>setBarStyle('light-content', true)</Text>
</View>
</TouchableHighlight>
<TouchableHighlight
style={styles.wrapper}
onPress={() => {
StatusBar.setNetworkActivityIndicatorVisible(true);
}}>
<View style={styles.button}>
<Text>setNetworkActivityIndicatorVisible(true)</Text>
</View>
</TouchableHighlight>
<TouchableHighlight
style={styles.wrapper}
onPress={() => {
StatusBar.setNetworkActivityIndicatorVisible(false);
}}>
<View style={styles.button}>
<Text>setNetworkActivityIndicatorVisible(false)</Text>
</View>
</TouchableHighlight>
</View>
);
}
Expand Down Expand Up @@ -490,13 +434,6 @@ exports.examples = [
return <StatusBarStyleExample />;
},
},
{
title: 'StatusBar network activity indicator',
render(): React.Node {
return <StatusBarNetworkActivityExample />;
},
platform: 'ios',
},
{
title: 'StatusBar background color',
render(): React.Node {
Expand Down