Do not implicitly convert parsed LengthPercentage to pixels#45987
Closed
NickGerleman wants to merge 2 commits into
Closed
Do not implicitly convert parsed LengthPercentage to pixels#45987NickGerleman wants to merge 2 commits into
NickGerleman wants to merge 2 commits into
Conversation
Summary: This adjusts logic to be similar to InsetBoxShadowDrawable to keep the full ink within RenderNode bounds. This avoids a tiny bit of overdraw, but also means we get correct rendering if RenderNode is promoted to a compositing layer. Changelog: [Internal] Differential Revision: D60972085
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D60507151 |
…#45987) Summary: Pull Request resolved: facebook#45987 This is a confusing public API, because styles layer deals with DIPs, conversion only happens when parsing dynamic, and `POINT` (the `LengthPercentageType`) also maps to DIPs instead of physical pixels. This moves conversion to physical pixels to drawing layer, so everything above `BackgroundStyleApplicator` works with `style` types which are all in DIPs. To preserve compatibility with existing APIs using raw radii, we keep it so that (most) views operate in pixel units, while view managers operate under DIPs. Changelog: [Android][Breaking] Do not implicitly convert parsed LengthPercentage to pixels Reviewed By: rshest Differential Revision: D60507151
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D60507151 |
NickGerleman
force-pushed
the
export-D60507151
branch
from
2cfd736 to
131e3f1
Compare
Contributor
|
This pull request has been merged in 9e48976. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
This is a confusing public API, because styles layer deals with DIPs, conversion only happens when parsing dynamic, and
POINT(theLengthPercentageType) also maps to DIPs instead of physical pixels.This moves conversion to physical pixels to drawing layer, so everything above
BackgroundStyleApplicatorworks withstyletypes which are all in DIPs.To preserve compatibility with existing APIs using raw radii, we keep it so that (most) views operate in pixel units, while view managers operate under DIPs.
Changelog: [Android][Breaking] Do not implicitly convert parsed LengthPercentage to pixels
Reviewed By: rshest
Differential Revision: D60507151