Appearance: Dedupe colorScheme Validation Logic#46120
Closed
yungsters wants to merge 3 commits into
Closed
Conversation
Summary: Straightforward migration of the `Appearance` module to use ESM named exports. Changelog: [Internal] Reviewed By: TheSavior Differential Revision: D61567882
Summary:
Updates `Appearance` on Android to supply the native module to `NativeEventEmitter` so that the native listener count can be managed like it is on iOS.
This was previously required by macOS and iOS. Android and Windows also already implement:
```
interface NativeModule {
addListener(eventType: string): void;
removeListeners(count: number): void;
}
```
So we should start passing `NativeAppearance` into the `NativeEventEmitter` constructor across all platforms.
Changelog:
[Internal]
Reviewed By: TheSavior
Differential Revision: D61567883
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D61567881 |
Summary: Pull Request resolved: facebook#46120 Currently, the implementation of `Appearance` duplicates the validation logic of string `colorScheme` values multiple times. This leads to more complicated code and also unnecessary work in certain edge cases (e.g. when `NativeAppearance` is not registered). This refactors `Appearance` to be simpler and to do less work. I've also configured `NativeAppearance.setColorScheme` to be non-nullable because it has existed since 2023. Changelog: [Internal] Reviewed By: TheSavior Differential Revision: D61567881
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D61567881 |
yungsters
force-pushed
the
export-D61567881
branch
from
7589377 to
e7c7a0c
Compare
Contributor
|
This pull request has been merged in ed3ca07. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Currently, the implementation of
Appearanceduplicates the validation logic of stringcolorSchemevalues multiple times.This leads to more complicated code and also unnecessary work in certain edge cases (e.g. when
NativeAppearanceis not registered).This refactors
Appearanceto be simpler and to do less work. I've also configuredNativeAppearance.setColorSchemeto be non-nullable because it has existed since 2023.Changelog:
[Internal]
Reviewed By: TheSavior
Differential Revision: D61567881