Fix dropShadow not creating stacking context#46143
Closed
jorge-cab wants to merge 1 commit into
Closed
Conversation
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D61617699 |
Summary: Before `drop-shadow` was not creating a stacking context causing its children to get flattened and not receive the shadow effect. This was due to incorrect parsing on C++. We didn't notice since we don't support `drop-shadow` on iOS and Android gets the parsed prop directly Changelog: [Internal] Reviewed By: NickGerleman, joevilches Differential Revision: D61617699
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D61617699 |
jorge-cab
force-pushed
the
export-D61617699
branch
from
19e4718 to
1ac59ba
Compare
Contributor
|
This pull request has been merged in baae360. |
Collaborator
|
This pull request was successfully merged by @jorge-cab in baae360 When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Before
drop-shadowwas not creating a stacking context causing its children to get flattened and not receive the shadow effect.This was due to incorrect parsing on C++. We didn't notice since we don't support
drop-shadowon iOS and Android gets the parsed prop directlyReviewed By: joevilches
Differential Revision: D61617699