Skip to content

reduce noisy systrace sections #46185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sammy-SC wants to merge 1 commit into from
Closed

reduce noisy systrace sections #46185

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 0 additions & 7 deletions packages/react-native/ReactCommon/react/renderer/core/ConcreteComponentDescriptor.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@
#include <memory>
#include <vector>

#include <cxxreact/SystraceSection.h>
#include <react/debug/react_native_assert.h>
#include <react/renderer/core/ComponentDescriptor.h>
#include <react/renderer/core/EventDispatcher.h>
Expand Down Expand Up @@ -67,7 +66,6 @@ class ConcreteComponentDescriptor : public ComponentDescriptor {
std::shared_ptr<ShadowNode> createShadowNode(
const ShadowNodeFragment& fragment,
const ShadowNodeFamily::Shared& family) const override {
SystraceSection s("ConcreteComponentDescriptor::createShadowNode");
auto shadowNode =
std::make_shared<ShadowNodeT>(fragment, family, getTraits());

Expand Down Expand Up @@ -99,7 +97,6 @@ class ConcreteComponentDescriptor : public ComponentDescriptor {
const PropsParserContext& context,
const Props::Shared& props,
RawProps rawProps) const override {
SystraceSection s1("ConcreteComponentDescriptor::cloneProps");
// Optimization:
// Quite often nodes are constructed with default/empty props: the base
// `props` object is `null` (there no base because it's not cloning) and the
Expand All @@ -125,8 +122,6 @@ class ConcreteComponentDescriptor : public ComponentDescriptor {
#else
const auto& dynamic = static_cast<folly::dynamic>(rawProps);
#endif
SystraceSection s2(
"ConcreteComponentDescriptor::cloneProps - iterateOverValues");
for (const auto& pair : dynamic.items()) {
const auto& name = pair.first.getString();
shadowNodeProps->setProp(
Expand All @@ -137,8 +132,6 @@ class ConcreteComponentDescriptor : public ComponentDescriptor {
}
return shadowNodeProps;
} else {
SystraceSection s3(
"ConcreteComponentDescriptor::cloneProps - old-style constructor");
// Call old-style constructor
return ShadowNodeT::Props(context, rawProps, props);
}
Expand Down
2 changes: 0 additions & 2 deletions packages/react-native/ReactCommon/react/renderer/core/RawProps.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,7 +162,6 @@ RawProps& RawProps::operator=(const RawProps& other) noexcept {
}

void RawProps::parse(const RawPropsParser& parser) noexcept {
SystraceSection s("RawProps::parse");
react_native_assert(parser_ == nullptr && "A parser was already assigned.");
parser_ = &parser;
parser.preparse(*this);
Expand All @@ -174,7 +173,6 @@ void RawProps::parse(const RawPropsParser& parser) noexcept {
* will be removed as soon Android implementation does not need it.
*/
RawProps::operator folly::dynamic() const noexcept {
SystraceSection s("RawProps::operator folly::dynamic()");
switch (mode_) {
case Mode::Empty:
return folly::dynamic::object();
Expand Down