Add more tests for border + child interaction#46195
Closed
joevilches wants to merge 4 commits into
Closed
Conversation
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D61695025 |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D61695025 |
joevilches
force-pushed
the
export-D61695025
branch
from
7a7b23a to
55524d0
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D61695025 |
joevilches
force-pushed
the
export-D61695025
branch
from
55524d0 to
a4be389
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D61695025 |
joevilches
force-pushed
the
export-D61695025
branch
from
a4be389 to
2240f35
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D61695025 |
joevilches
force-pushed
the
export-D61695025
branch
from
2240f35 to
07273dc
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D61695025 |
joevilches
force-pushed
the
export-D61695025
branch
from
07273dc to
e16850b
Compare
Differential Revision: D61414649
Differential Revision: D61248625
Differential Revision: D61418470
Summary: Pull Request resolved: facebook#46195 go tests! Testing * Symmetrical, transparent border clips to padding box (wrong behavior atm) * Asymmetrical, transparent border clips to padding box (wrong behavior atm) * Children render over borders with no clipping (correct behavior atm) Changelog: [Internal] Reviewed By: NickGerleman Differential Revision: D61695025
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D61695025 |
joevilches
force-pushed
the
export-D61695025
branch
from
e16850b to
1386627
Compare
Contributor
|
This pull request has been merged in defb0bd. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
go tests!
Testing
Changelog: [Internal]
Differential Revision: D61695025