feat: linear gradient transition hint syntax#46219
Closed
intergalacticspacehighway wants to merge 3 commits into
Closed
feat: linear gradient transition hint syntax#46219intergalacticspacehighway wants to merge 3 commits into
intergalacticspacehighway wants to merge 3 commits into
Conversation
facebook-github-bot
added
CLA Signed
intergalacticspacehighway
force-pushed
the
linear-gradient-transition-hints
branch
2 times, most recently
from
9e2c636 to
e73db98
Compare
intergalacticspacehighway
force-pushed
the
linear-gradient-transition-hints
branch
from
d57598c to
e67bf9b
Compare
Contributor
Author
|
Closed in favor of #48410 This one has some bad merge history and some merge restrictions are getting triggered. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
processColorTransitionHintis put into native code so it can support platform colors.Changelog:
[GENERAL] [ADDED] - Linear gradient color transition hint syntax support.
Test Plan:
Added testcase in processBackgroundImage-test.ts and example in LinearGradientExample.js
Thoughts
Linear gradient fully supports CSS syntax with percentage value color stop positions and this PR adds transition hint support so can we remove experimental status from it?
pxsupport can be done but we'll need to move color stop fixup algorithm from JS to native as we'll need view dimensions to support mixing percentage andpxvalues. I guess we can hold that until new CSS parser?