Fix NativeModuleEnumMembers type#46222
Closed
elicwhite wants to merge 2 commits into
Closed
Conversation
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D61830075 |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D61830075 |
elicwhite
force-pushed
the
export-D61830075
branch
from
27c55dc to
3cddf11
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D61830075 |
elicwhite
force-pushed
the
export-D61830075
branch
from
3cddf11 to
3e9a88d
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D61830075 |
elicwhite
force-pushed
the
export-D61830075
branch
from
3e9a88d to
1c8624e
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D61830075 |
elicwhite
force-pushed
the
export-D61830075
branch
from
1c8624e to
b40bd95
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D61830075 |
elicwhite
force-pushed
the
export-D61830075
branch
from
b40bd95 to
4c6495b
Compare
Summary: Previously the schema special cased unparseable elementType with elementType just being undefined. This causes issues for logic that requires recursively matching types. Instead of being implicit, this makes them explicitly an AnyTypeAnnotation Differential Revision: D61825742
Summary: Pull Request resolved: facebook#46222 This value was typed as always being a string, even though it was containing both strings and numbers in the fixtures. This was because on this line https://fburl.com/code/9j7gh4av the input type is $FlowFixMe (from the source AST), which wasn't catching that it couldn't flow into just `string`. Changelog: [Internal] Reviewed By: makovkastar Differential Revision: D61830075
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D61830075 |
elicwhite
force-pushed
the
export-D61830075
branch
from
4c6495b to
b2d59f0
Compare
Contributor
|
This pull request has been merged in a536311. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: This value was typed as always being a string, even though it was containing both strings and numbers in the fixtures. This was because on this line https://fburl.com/code/9j7gh4av the input type is $FlowFixMe (from the source AST), which wasn't catching that it couldn't flow into just
string.Differential Revision: D61830075