Refactoring: extract helper functions from StatusBarModule#46224
Closed
alanleedev wants to merge 1 commit into
Closed
Refactoring: extract helper functions from StatusBarModule#46224alanleedev wants to merge 1 commit into
alanleedev wants to merge 1 commit into
Conversation
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D61834841 |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D61834841 |
alanleedev
force-pushed
the
export-D61834841
branch
from
004d1d7 to
21735ae
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D61834841 |
alanleedev
force-pushed
the
export-D61834841
branch
from
21735ae to
e7206f2
Compare
…46224) Summary: Pull Request resolved: facebook#46224 - Extract functions from StatusBarModule so they can be reused - WindowUtil was created as a container for the extracted Window related helper functions Changelog: [Internal] Reviewed By: tdn120 Differential Revision: D61834841
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D61834841 |
alanleedev
force-pushed
the
export-D61834841
branch
from
e7206f2 to
25c8296
Compare
alanleedev
added a commit
to alanleedev/react-native
that referenced
this pull request
Aug 29, 2024
…46224) Summary: Pull Request resolved: facebook#46224 - Extract functions from StatusBarModule so they can be reused - WindowUtil was created as a container for the extracted Window related helper functions Changelog: [Internal] Differential Revision: D61834841 Reviewed By: tdn120
Contributor
|
This pull request has been merged in 768415d. |
Collaborator
|
This pull request was successfully merged by @alanleedev in 768415d When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog: [Internal]
Differential Revision: D61834841