Start looking for codegen-enabled dependencies from the project root#46229
Closed
dmytrorykun wants to merge 1 commit into
Closed
Start looking for codegen-enabled dependencies from the project root#46229dmytrorykun wants to merge 1 commit into
dmytrorykun wants to merge 1 commit into
Conversation
Summary: When running codegen from `pod install`, something affects `require.resolve`, and it starts looking for codegen-enabled dependencies from the workspace root, not the current RN project root. This is bad if we have different versions of same dependency across multiple workspaces. One of them will be hoisted to the workspace root, and will be used for all the workspaces. This issue is described in details here facebook#46196 This diff is supposed to fix this by adding the project root path to the `require.resolve` call. Changelog: [iOS][Fixed] - Codegen will start looking for codegen-enabled dependencies from the project root. Differential Revision: D61850219
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D61850219 |
Contributor
|
This pull request has been merged in 46d17ef. |
Collaborator
|
This pull request was successfully merged by @dmytrorykun in 46d17ef When will my fix make it into a release? | How to file a pick request? |
cipolleschi
pushed a commit
that referenced
this pull request
Sep 11, 2024
…46229) Summary: Pull Request resolved: #46229 When running codegen from `pod install`, something affects `require.resolve`, and it starts looking for codegen-enabled dependencies from the workspace root, not the current RN project root. This is bad if we have different versions of same dependency across multiple workspaces. One of them will be hoisted to the workspace root, and will be used for all the workspaces. This issue is described in details here #46196 This diff is supposed to fix this by adding the project root path to the `require.resolve` call. Changelog: [iOS][Fixed] - Codegen will start looking for codegen-enabled dependencies from the project root. Reviewed By: cipolleschi Differential Revision: D61850219 fbshipit-source-id: d60a0e72e9c60e862c0d64e227ea3652d1be5a90
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
When running codegen from
pod install, something affectsrequire.resolve, and it starts looking for codegen-enabled dependencies from the workspace root, not the current RN project root.This is bad if we have different versions of same dependency across multiple workspaces. One of them will be hoisted to the workspace root, and will be used for all the workspaces.
This issue is described in details here #46196
This diff is supposed to fix this by adding the project root path to the
require.resolvecall.Changelog: [iOS][Fixed] - Codegen will start looking for codegen-enabled dependencies from the project root.
Differential Revision: D61850219