Get filter to show up with CoreFeatures::enablePropIteratorSetter#46234
Closed
joevilches wants to merge 1 commit into
Closed
Get filter to show up with CoreFeatures::enablePropIteratorSetter#46234joevilches wants to merge 1 commit into
joevilches wants to merge 1 commit into
Conversation
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D61861547 |
…Setter (facebook#46234) Summary: Pull Request resolved: facebook#46234 We were seeing some cases of these not working and that was because CoreFeatures::enablePropIteratorSetter was set to true and we need to add this line for it to parse with that Changelog: [Internal] Reviewed By: NickGerleman Differential Revision: D61861547
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D61861547 |
joevilches
force-pushed
the
export-D61861547
branch
from
e6927d1 to
4b64b07
Compare
Contributor
|
This pull request has been merged in b01da5e. |
Collaborator
|
This pull request was successfully merged by @joevilches in b01da5e When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: We were seeing some cases of filter not working and that was because CoreFeatures::enablePropIteratorSetter was set to true and we need to add this line for it to parse with that
Reviewed By: NickGerleman
Differential Revision: D61861547