Move reporting of long tasks to before updating rendering#46252
Closed
rubennorte wants to merge 1 commit into
Closed
Move reporting of long tasks to before updating rendering#46252rubennorte wants to merge 1 commit into
rubennorte wants to merge 1 commit into
Conversation
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D61939261 |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D61939261 |
rubennorte
force-pushed
the
export-D61939261
branch
from
9014cd4 to
d128c93
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D61939261 |
rubennorte
force-pushed
the
export-D61939261
branch
from
d128c93 to
d2692e2
Compare
…6252) Summary: Pull Request resolved: facebook#46252 Changelog: [internal] The long task API should only account for work specifically done by the task. Updating the rendering shouldn't be considered for that, so this moves the determination of long tasks before doing that work. Reviewed By: sammy-SC, rshest Differential Revision: D61939261
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D61939261 |
rubennorte
force-pushed
the
export-D61939261
branch
from
d2692e2 to
370fbaf
Compare
Contributor
|
This pull request has been merged in a0909ef. |
Collaborator
|
This pull request was successfully merged by @rubennorte in a0909ef When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog: [internal]
The long task API should only account for work specifically done by the task. Updating the rendering shouldn't be considered for that, so this moves the determination of long tasks before doing that work.
Differential Revision: D61939261