Skip to content

Cache vector image detection for assets #46415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
lenaic wants to merge 1 commit into from
Closed

Cache vector image detection for assets #46415

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion ...actAndroid/src/main/java/com/facebook/react/views/imagehelper/ResourceDrawableIdHelper.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ import org.xmlpull.v1.XmlPullParser
@ThreadSafe
public class ResourceDrawableIdHelper private constructor() {
private val resourceDrawableIdMap: MutableMap<String, Int> = HashMap()
private val vectorDrawableCheckCache: MutableMap<Context, MutableMap<String, Boolean>> = HashMap()

@Synchronized
public fun clear() {
Expand Down Expand Up @@ -64,7 +65,15 @@ public class ResourceDrawableIdHelper private constructor() {
}

public fun isVectorDrawable(context: Context, name: String): Boolean {
return getOpeningXmlTag(context, name) == "vector"
val cachedResult = vectorDrawableCheckCache[context]?.get(name);
if (cachedResult != null) {
return cachedResult
}


val result = getOpeningXmlTag(context, name) == "vector"
vectorDrawableCheckCache.getOrPut(context, { HashMap() }).put(name, result)
return result
}

/**
Expand Down