fix(iOS): fallback to old path when dynamic resolve fails#46432
Closed
okwasniewski wants to merge 1 commit into
Closed
fix(iOS): fallback to old path when dynamic resolve fails#46432okwasniewski wants to merge 1 commit into
okwasniewski wants to merge 1 commit into
Conversation
facebook-github-bot
added
the
CLA Signed
okwasniewski
changed the title
facebook-github-bot
added
p: Callstack
Contributor
Author
|
cc: @cipolleschi |
cipolleschi
approved these changes
Sep 12, 2024
Contributor
|
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Contributor
|
@cipolleschi merged this pull request in 3cbaddb. |
Collaborator
|
This pull request was successfully merged by @okwasniewski in 3cbaddb When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
This PR is a follow-up after #46181 this change makes sure that if the
require.resolvefails we still fall back to the old behavior.The
require.resolvewas failing for local builds of OOT platforms (because in OOT platforms mono reporeact-nativeis renamed toreact-native-platform-name)Changelog:
[IOS] [FIXED] - Fallback to old resolve mechanism when node require fails to resolve react native path
Test Plan:
CI Green