Fix SVC for RNTester iOS#46439
Closed
cipolleschi wants to merge 1 commit into
Closed
Conversation
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D62501704 |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D62501704 |
cipolleschi
force-pushed
the
export-D62501704
branch
from
031154e to
951a5c3
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D62501704 |
cipolleschi
force-pushed
the
export-D62501704
branch
from
951a5c3 to
5e2fe06
Compare
Summary: Pull Request resolved: facebook#46439 The SVC for some components on iOS got out of sync. This was creating warnings in the React Native DevTools and it was affecting the release of 0.76. With this change, I updated the manually written SVC so that we don't have warnings anymore. We still have to fix the `boxShadow` and `filter`. This will happen in a later change. ## Changelog [iOS][Fixed] - Solved SVC warnings for RNTester Reviewed By: NickGerleman Differential Revision: D62501704
cipolleschi
added a commit
to cipolleschi/react-native
that referenced
this pull request
Sep 13, 2024
Summary: Pull Request resolved: facebook#46439 The SVC for some components on iOS got out of sync. This was creating warnings in the React Native DevTools and it was affecting the release of 0.76. With this change, I updated the manually written SVC so that we don't have warnings anymore. ## Changelog [iOS][Fixed] - Solved SVC warnings for RNTester Differential Revision: D62501704
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D62501704 |
cipolleschi
force-pushed
the
export-D62501704
branch
from
5e2fe06 to
91a35aa
Compare
Contributor
|
This pull request has been merged in fad4a07. |
Collaborator
|
This pull request was successfully merged by @cipolleschi in fad4a07 When will my fix make it into a release? | How to file a pick request? |
cipolleschi
added a commit
that referenced
this pull request
Sep 16, 2024
Summary: Pull Request resolved: #46439 The SVC for some components on iOS got out of sync. This was creating warnings in the React Native DevTools and it was affecting the release of 0.76. With this change, I updated the manually written SVC so that we don't have warnings anymore. We still have to fix the `boxShadow` and `filter`. This will happen in a later change. ## Changelog [iOS][Fixed] - Solved SVC warnings for RNTester Reviewed By: NickGerleman Differential Revision: D62501704 fbshipit-source-id: 3c02f7615c3511a97eba73a2ddaa713d2e4e30f0
This was referenced Apr 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
The SVC for some components on iOS got out of sync.
This was creating warnings in the React Native DevTools and it was affecting the release of 0.76.
With this change, I updated the manually written SVC so that we don't have warnings anymore.
Changelog
[iOS][Fixed] - Solved SVC warnings for RNTester
Differential Revision: D62501704