Animated: Switch to useInsertionEffect#46474
Closed
yungsters wants to merge 1 commit into
Closed
Conversation
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D62602336 |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D62602336 |
yungsters
force-pushed
the
export-D62602336
branch
from
e7365ea to
c155609
Compare
Summary: Pull Request resolved: facebook#46474 Changes `useAnimatedPropsLifecycle_passiveEffects` (the experimental lifecycle management in `useAnimatedProps`) to `useInsertionEffect` instead of `useEffect`. This has a few benefits: 1. Prevents any Activity detach and attach events from triggering Animated lifecycle work (which adds to effect mounting and unmounting time). 2. Fixes batching of native Animated operations across components. (Since we flush the operation queue in a passive effect, enqueueing operations in a passive effect causes weird interleaving of enqueuing and flushing.) 3. Enables animations to be started in layout effects. Changelog: [Internal] Differential Revision: D62602336
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D62602336 |
yungsters
force-pushed
the
export-D62602336
branch
from
c155609 to
b5b30c5
Compare
Contributor
|
This pull request has been merged in 1c7fd8b. |
Collaborator
|
This pull request was successfully merged by @yungsters in 1c7fd8b When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Changes
useAnimatedPropsLifecycle_passiveEffects(the experimental lifecycle management inuseAnimatedProps) touseInsertionEffectinstead ofuseEffect.The primary motivation for this change is avoiding detaching and attaching of animations when an enclosing
Activity's mode changed from visible to hidden and back to visible.Changelog:
[Internal]
Differential Revision: D62602336