Rename DropShadowPrimitive to DropShadowValue#46476
Closed
jorge-cab wants to merge 2 commits into
Closed
Conversation
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D62614579 |
Differential Revision: D62614444
Summary: Pull Request resolved: facebook#46476 Keep the type naming consistent with examples like `DimensionValue`, `ColorValue`, etc. Changelog: [Internal] Reviewed By: NickGerleman Differential Revision: D62614579
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D62614579 |
jorge-cab
force-pushed
the
export-D62614579
branch
from
ee5de64 to
e8b18d8
Compare
Contributor
|
This pull request has been merged in 6f84b63. |
cipolleschi
pushed a commit
that referenced
this pull request
Sep 16, 2024
Summary: Pull Request resolved: #46476 Keep the type naming consistent with examples like `DimensionValue`, `ColorValue`, etc. Changelog: [Internal] Reviewed By: NickGerleman Differential Revision: D62614579 fbshipit-source-id: 824ea9af17487a4459e8f39d9374e2e00452db43
This was referenced Apr 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Keep the type naming consistent with examples like
DimensionValue,ColorValue, etc.Changelog: [Internal]
Differential Revision: D62614579