RNGP - Sanitize the output of the config command#46482
Closed
cortinico wants to merge 1 commit into
Closed
Conversation
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D62641979 |
This was referenced Sep 13, 2024
Summary: Pull Request resolved: facebook#46482 Fixes facebook#46443 Fixes facebook#46134 I'm sanitizing the output of the `config` command + I've added some more logging in case of failure. Changelog: [Android] [Fixed] - RNGP - Sanitize the output of the config command Reviewed By: cipolleschi Differential Revision: D62641979
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D62641979 |
fc52d34 to
647a478
Compare
Contributor
|
This pull request has been merged in d7884a6. |
Collaborator
|
This pull request was successfully merged by @cortinico in d7884a6 When will my fix make it into a release? | How to file a pick request? |
cipolleschi
pushed a commit
that referenced
this pull request
Sep 16, 2024
Summary: Pull Request resolved: #46482 Fixes #46443 Fixes #46134 I'm sanitizing the output of the `config` command + I've added some more logging in case of failure. Changelog: [Android] [Fixed] - RNGP - Sanitize the output of the config command Reviewed By: cipolleschi Differential Revision: D62641979 fbshipit-source-id: c13d27a42beeb7a973c1802e7204631d49d3d09b
blakef
pushed a commit
that referenced
this pull request
Sep 30, 2024
Summary: Pull Request resolved: #46482 Fixes #46443 Fixes #46134 I'm sanitizing the output of the `config` command + I've added some more logging in case of failure. Changelog: [Android] [Fixed] - RNGP - Sanitize the output of the config command Reviewed By: cipolleschi Differential Revision: D62641979 fbshipit-source-id: c13d27a42beeb7a973c1802e7204631d49d3d09b
This was referenced Apr 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Fixes #46443
Fixes #46134
I'm sanitizing the output of the
configcommand + I've added some more logging in case of failure.Changelog:
[Android] [Fixed] - RNGP - Sanitize the output of the config command
Differential Revision: D62641979