Animated: Restore AnimatedNode.prototype.toJSON#46498
Closed
yungsters wants to merge 1 commit into
Closed
Conversation
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D62690380 |
Summary: Pull Request resolved: facebook#46498 Looks like this is still necessary because we still run into this error when using the Components tab when using React DevTools: > TypeError: cyclical structure in JSON object This effectively reverts facebook#46382. Changelog: [General][Changed] - AnimatedNode (and its subclasses) once again implement `toJSON()`. Reviewed By: javache Differential Revision: D62690380
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D62690380 |
yungsters
force-pushed
the
export-D62690380
branch
from
0852e82 to
a2b9ca1
Compare
Contributor
|
This pull request has been merged in 7bd4a54. |
Collaborator
|
This pull request was successfully merged by @yungsters in 7bd4a54 When will my fix make it into a release? | How to file a pick request? |
cipolleschi
pushed a commit
that referenced
this pull request
Sep 16, 2024
Summary: Pull Request resolved: #46498 Looks like this is still necessary because we still run into this error when using the Components tab when using React DevTools: > TypeError: cyclical structure in JSON object This effectively reverts #46382. Changelog: [General][Changed] - AnimatedNode (and its subclasses) once again implement `toJSON()`. Reviewed By: javache Differential Revision: D62690380 fbshipit-source-id: d5b7c1d156b49838abefe48a7d7b61471cc3488a
cipolleschi
added a commit
that referenced
this pull request
Sep 16, 2024
This reverts commit 83eb95e.
This was referenced Apr 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Looks like this is still necessary because we still run into this error when using the Components tab when using React DevTools:
This effectively reverts #46382.
Changelog:
[General][Changed] - AnimatedNode (and its subclasses) once again implement
toJSON().Differential Revision: D62690380