fix race condition in IntentModule.mInitialURLListener#46499
Closed
sammy-SC wants to merge 1 commit into
Closed
Conversation
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D62698183 |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D62698183 |
sammy-SC
force-pushed
the
export-D62698183
branch
from
40db98d to
382e3a4
Compare
Summary: Pull Request resolved: facebook#46499 changelog: [internal] IntentModule.mInitialURLListener is accessed and mutated on three different threads and is missing synchronisation. 1. In [waitForActivityAndGetInitialURL](https://github.com/facebook/react-native/blob/main/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/modules/intent/IntentModule.java#L83) it is accessed and mutated from thread mqt_v_native. 2. In [LifecycleEventListener](https://github.com/facebook/react-native/blob/main/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/modules/intent/IntentModule.java#L97) it is mutated from the main thread. 3. In [invalidate](https://github.com/facebook/react-native/blob/main/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/modules/intent/IntentModule.java#L44) it is read and mutated on a another thread. Reviewed By: javache Differential Revision: D62698183
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D62698183 |
sammy-SC
force-pushed
the
export-D62698183
branch
from
382e3a4 to
e966e13
Compare
Contributor
|
This pull request has been merged in b63ec30. |
Collaborator
|
This pull request was successfully merged by @sammy-SC in b63ec30 When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
changelog: [internal]
IntentModule.mInitialURLListener is accessed and mutated on three different threads and is missing synchronisation.
In waitForActivityAndGetInitialURL it is accessed and mutated from thread mqt_v_native.
In LifecycleEventListener it is mutated from the main thread.
In invalidate it is read and mutated on a another thread.
Reviewed By: javache
Differential Revision: D62698183