fix(iOS): move boost compiler flags and folly dep name to centralized config#46513
Closed
okwasniewski wants to merge 1 commit into
Closed
fix(iOS): move boost compiler flags and folly dep name to centralized config#46513okwasniewski wants to merge 1 commit into
okwasniewski wants to merge 1 commit into
Conversation
facebook-github-bot
added
CLA Signed
Contributor
|
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
cipolleschi
approved these changes
Sep 17, 2024
Contributor
cipolleschi
left a comment
cipolleschi
left a comment
There was a problem hiding this comment.
Thanks for spending time consolidating our build infra!
Contributor
|
@cipolleschi merged this pull request in 3c17bea. |
Collaborator
|
This pull request was successfully merged by @okwasniewski in 3c17bea When will my fix make it into a release? | How to file a pick request? |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
This PR does some further cleanup on the flags passed to cocoapods.
I've moved
boost_compiler_flagsandfolly_dep_nametohelpers.rbfile.Changelog:
[INTERNAL] [FIXED] - move boost compiler flags and folly dep name to centralized config
Test Plan:
CI Green