Fix misleading crash when view config is not found (#30970)#46518
Closed
javache wants to merge 1 commit into
Closed
Fix misleading crash when view config is not found (#30970)#46518javache wants to merge 1 commit into
javache wants to merge 1 commit into
Conversation
Summary: ## Summary When a view config can not be found, it currently errors with `TypeError: Cannot read property 'bubblingEventTypes' of null`. Instead invariant at the correct location and prevent further processing of the null viewConfig to improve the error logged. ## How did you test this change? Build and run RN playground app referencing an invalid native view through `requireNativeComponent`. Changelog: [General][Fixed] Improved error message when no view config is found. DiffTrain build for commit facebook/react@26855e4. Differential Revision: D62760863 Pulled By: javache
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D62760863 |
Contributor
Collaborator
|
This pull request was successfully merged by @javache in bca232a When will my fix make it into a release? | How to file a pick request? |
Member
Author
Please report a bug in the React Native repo with the relevant details and a reproducer, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Summary
When a view config can not be found, it currently errors with
TypeError: Cannot read property 'bubblingEventTypes' of null. Insteadinvariant at the correct location and prevent further processing of the
null viewConfig to improve the error logged.
How did you test this change?
Build and run RN playground app referencing an invalid native view
through
requireNativeComponent.Changelog: [General][Fixed] Improved error message when no view config is found.
DiffTrain build for commit facebook/react@26855e4.
Differential Revision: D62760863
Pulled By: javache