Fix setImmediate/clearTimeout mismatch in NativeAnimatedHelper#46525
Closed
bgirard wants to merge 1 commit into
Closed
Fix setImmediate/clearTimeout mismatch in NativeAnimatedHelper#46525bgirard wants to merge 1 commit into
bgirard wants to merge 1 commit into
Conversation
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D62775703 |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D62775703 |
bgirard
force-pushed
the
export-D62775703
branch
from
c3853ae to
874bc18
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D62775703 |
bgirard
force-pushed
the
export-D62775703
branch
from
874bc18 to
debdc28
Compare
…ook#46525) Summary: Pull Request resolved: facebook#46525 While debugging I noticed that my setTimout was being cleared by someone else. Upon further inspection I found NativeAnimatedHelper which was mismatching setImmediate timer handle with a clearTimeout. This isn't safe and needs to be fixed. I used this to rename the timer to be more clear to reduce the changes of mismatches. Changelog: [General][Fixed] - Fix setImmediate/clearTimeout mismatch in NativeAnimatedHelper that could clear an unrelated setTimeout. Reviewed By: javache, yungsters Differential Revision: D62775703
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D62775703 |
bgirard
force-pushed
the
export-D62775703
branch
from
debdc28 to
bf3cfbf
Compare
Contributor
|
This pull request has been merged in a5dd1be. |
Collaborator
|
This pull request was successfully merged by Benoit Girard in a5dd1be When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
While debugging I noticed that my setTimout was being cleared by someone else. Upon further inspection I found NativeAnimatedHelper which was mismatching setImmediate timer handle with a clearTimeout. This isn't safe and needs to be fixed.
I used this to rename the timer to be more clear to reduce the changes of mismatches.
Changelog: Fix setImmediate/clearTimeout mismatch in NativeAnimatedHelper that could clear an unrelated setTimeout.
Differential Revision: D62775703