execute task directly instead of going through runEventLoopTick#46540
Closed
sammy-SC wants to merge 1 commit into
Closed
execute task directly instead of going through runEventLoopTick#46540sammy-SC wants to merge 1 commit into
sammy-SC wants to merge 1 commit into
Conversation
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D62871782 |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D62871782 |
sammy-SC
force-pushed
the
export-D62871782
branch
from
86e5f05 to
d0e2ca1
Compare
sammy-SC
force-pushed
the
export-D62871782
branch
from
d0e2ca1 to
091b35c
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D62871782 |
…book#46540) Summary: Pull Request resolved: facebook#46540 changelog: [internal] avoid calling `runEventLoopTick` and execute task directly. runEventLoopTick is not designed to be called on re-entries. Reviewed By: rubennorte Differential Revision: D62871782
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D62871782 |
sammy-SC
force-pushed
the
export-D62871782
branch
from
091b35c to
2b6fbe2
Compare
Contributor
|
This pull request has been merged in 0fe234c. |
Collaborator
|
This pull request was successfully merged by @sammy-SC in 0fe234c When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
changelog: [internal]
avoid calling
runEventLoopTickand execute task directly. runEventLoopTick is not designed to be called on re-entries.Differential Revision: D62871782