Skip to content

Fix AnimatedEvent leaking topScrollEnded handler #46576

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
javache wants to merge 1 commit into from
Closed

Fix AnimatedEvent leaking topScrollEnded handler #46576

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion ...ve/ReactAndroid/src/main/java/com/facebook/react/animated/NativeAnimatedNodesManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -556,7 +556,6 @@ public void addAnimatedEventToView(
@UiThread
public void removeAnimatedEventFromView(
int viewTag, String eventHandlerName, int animatedValueTag) {

String eventName = normalizeEventName(eventHandlerName);

ListIterator<EventAnimationDriver> it = mEventDrivers.listIterator();
Expand All @@ -569,6 +568,11 @@ public void removeAnimatedEventFromView(
break;
}
}

if (eventName.equals("topScroll")) {
// Handle the custom topScrollEnded event sent by the ScrollViews when the user stops dragging
removeAnimatedEventFromView(viewTag, "topScrollEnded", animatedValueTag);
}
}

@Override
Expand Down