Move ShadowNodePair to Differentiator#46590
Closed
javache wants to merge 2 commits intofacebook:mainfrom
Closed
Conversation
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D63148522 |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D63148522 |
javache
force-pushed
the
export-D63148522
branch
from
d0d3144 to
12d330b
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D63148522 |
javache
force-pushed
the
export-D63148522
branch
from
12d330b to
2c21838
Compare
Differential Revision: D63099721
Summary: Pull Request resolved: facebook#46590 This API should not be part of the ShadowView header, since the class is only used by Differentiator. The ShadowView header should contain public API's that the mounting layer can consume. Changelog: [Internal] Reviewed By: sammy-SC Differential Revision: D63148522
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D63148522 |
javache
force-pushed
the
export-D63148522
branch
from
2c21838 to
04fbd77
Compare
Contributor
|
This pull request has been merged in a6fcad7. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
This API should not be part of the ShadowView header, since the class is only used by Differentiator. The ShadowView header should contain public API's that the mounting layer can consume.
Changelog: [Internal]
Differential Revision: D63148522