Remove unused FabricComponents mapping#46591
Closed
javache wants to merge 2 commits into
Closed
Conversation
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D63099721 |
Differential Revision: D63099720
Summary: Pull Request resolved: facebook#46591 This is a duplicate of FabricNameComponentMapping, which is not exposed. Checking GitHub codesearch, this API is not referenced elsewhere. This component should be cleaned, with the mappings moved to a generic translation layer (eg in [ViewManagerRegistry](https://github.com/facebook/react-native/blob/main/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/uimanager/ViewManagerRegistry.java#L55)) or by fixing the JS callers. Changelog: [Android][Removed] FabricComponents is removed from public API Reviewed By: fabriziocucci Differential Revision: D63099721
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D63099721 |
javache
force-pushed
the
export-D63099721
branch
from
3457a47 to
bfbe412
Compare
Contributor
|
This pull request has been merged in 300db67. |
Collaborator
|
This pull request was successfully merged by @javache in 300db67 When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
This is a duplicate of FabricNameComponentMapping, which is not exposed. Checking GitHub codesearch, this API is not referenced elsewhere.
This component should be cleaned, with the mappings moved to a generic translation layer (eg in ViewManagerRegistry) or by fixing the JS callers.
Changelog: [Android][Removed] FabricComponents is removed from public API
Reviewed By: fabriziocucci
Differential Revision: D63099721