ReactFragment should properly instantiate ReactDelegate on Bridgeless#46623
Closed
cortinico wants to merge 1 commit into
Closed
ReactFragment should properly instantiate ReactDelegate on Bridgeless#46623cortinico wants to merge 1 commit into
cortinico wants to merge 1 commit into
Conversation
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D63319977 |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D63319977 |
cortinico
force-pushed
the
export-D63319977
branch
from
7856526 to
34a0fc3
Compare
This was referenced Sep 26, 2024
…facebook#46623) Summary: Pull Request resolved: facebook#46623 I've just noticed that ReactFragment is not properly instantiating the `ReactDelegate` with a ReactHost when on Bridgeless. This causes Fragments to crash when the app is on bridgeless mode. Fixes facebook#46566 Changelog: [Android] [Fixed] - ReactFragment should properly instantiate ReactDelegate on Bridgeless Reviewed By: mdvacca Differential Revision: D63319977
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D63319977 |
cortinico
force-pushed
the
export-D63319977
branch
from
34a0fc3 to
fedad31
Compare
Contributor
|
This pull request has been merged in 7176d11. |
Collaborator
|
This pull request was successfully merged by @cortinico in 7176d11 When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
I've just noticed that ReactFragment is not properly instantiating the
ReactDelegatewith a ReactHostwhen on Bridgeless. This causes Fragments to crash when the app is on bridgeless mode.
Fixes #46566
Changelog:
[Android] [Fixed] - ReactFragment should properly instantiate ReactDelegate on Bridgeless
Differential Revision: D63319977