ReactViewGroup post-conversion cleanup#46668
Closed
tdn120 wants to merge 3 commits into
Closed
Conversation
…pingViewManager to Kotlin"" Summary: Original commit changeset: 9cbd8ab86be3 Original Phabricator Diff: D63076764 Differential Revision: D63129925
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D63343964 |
added 2 commits
September 26, 2024 10:33
Summary: Original commit changeset: 01d3949c1312 Original Phabricator Diff: D63076763 Differential Revision: D63129923
Summary: Pull Request resolved: facebook#46668 Small tweaks post-Kotlin-conversion: - Make `overflow` a var - Replace `+ -` with `-` - Clean up properties and move up init block - Iterate over entire allChildren array to clean up listeners Changelog: [Internal] Reviewed By: cortinico Differential Revision: D63343964
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D63343964 |
tdn120
force-pushed
the
export-D63343964
branch
from
483428f to
c064465
Compare
Contributor
|
This pull request has been merged in 9cd83fa. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Small tweaks post-Kotlin-conversion:
overflowa var+ -with-Changelog: [Internal]
Reviewed By: cortinico
Differential Revision: D63343964