Skip to content

Add Modal Testing to modal.yml#46796

Closed
ahmedbilal008 wants to merge 3 commits into
facebook:mainfrom
ahmedbilal008:updating-yml-test
Closed

Add Modal Testing to modal.yml#46796
ahmedbilal008 wants to merge 3 commits into
facebook:mainfrom
ahmedbilal008:updating-yml-test

Conversation

@ahmedbilal008
Copy link
Copy Markdown
Contributor

@ahmedbilal008 ahmedbilal008 commented Oct 2, 2024

Summary:

This pr is part of issue #46757 solving tasks [ME2E0001] and [ME2E0002].

Changelog:

[ Internal ] [ Added ] - Add e2e test for modal

Test Plan:

yarn e2e-test-ios
yarn e2e-test-android

@facebook-github-bot
Copy link
Copy Markdown
Contributor

Hi @ahmedbilal008!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@facebook-github-bot
Copy link
Copy Markdown
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. labels Oct 2, 2024
@ahmedbilal008
Copy link
Copy Markdown
Contributor Author

/test-e2e

@facebook-github-bot
Copy link
Copy Markdown
Contributor

@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@cipolleschi
Copy link
Copy Markdown
Contributor

/rebase - this comment automatically rebase on top of main

@facebook-github-bot
Copy link
Copy Markdown
Contributor

@cipolleschi merged this pull request in 1a2532b.

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Oct 4, 2024
@react-native-bot
Copy link
Copy Markdown
Collaborator

This pull request was successfully merged by @ahmedbilal008 in 1a2532b

When will my fix make it into a release? | How to file a pick request?

@ahmedbilal008 ahmedbilal008 deleted the updating-yml-test branch October 4, 2024 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants