Skip to content

[0.76][Fix] Restore Metro log forwarding, change notice to signal future removal #46815

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
blakef merged 1 commit into from
Oct 7, 2024
+11 −6
Merged

[0.76][Fix] Restore Metro log forwarding, change notice to signal future removal #46815

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion packages/react-native/Libraries/Core/setUpDeveloperTools.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,9 +42,13 @@ if (__DEV__) {
if (!Platform.isTesting) {
const HMRClient = require('../Utilities/HMRClient');

// [0.76 only] When under React Native DevTools, log "JavaScript logs will
// be removed from Metro..." warning, and continue to forward logs.
if (global.__FUSEBOX_HAS_FULL_CONSOLE_SUPPORT__) {
HMRClient.unstable_notifyFuseboxConsoleEnabled();
} else if (console._isPolyfilled) {
}

if (console._isPolyfilled) {
// We assume full control over the console and send JavaScript logs to Metro.
[
'trace',
Expand Down
11 changes: 6 additions & 5 deletions packages/react-native/Libraries/Utilities/HMRClient.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,11 +153,12 @@ const HMRClient: HMRClientNativeInterface = {
level: 'info',
data: [
'\n' +
'\x1b[7m' +
' \x1b[1mJavaScript logs have moved!\x1b[22m They will now appear in the debugger console. ' +
'Tip: Type \x1b[1mj\x1b[22m in the terminal to open the debugger (requires Google Chrome ' +
'or Microsoft Edge).' +
'\x1b[27m' +
'\u001B[7m' +
' \u001B[1m💡 JavaScript logs will be removed from Metro in React ' +
'Native 0.77!\u001B[22m Please use React Native DevTools as your ' +
'default tool. Tip: Type \u001B[1mj\u001B[22m in the terminal to ' +
'open (requires Google Chrome or Microsoft Edge).' +
'\u001B[27m' +
'\n',
],
}),
Expand Down