Change type of shadows from array to LayerDrawable#46818
Closed
jorge-cab wants to merge 1 commit into
Closed
Conversation
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D63798842 |
jorge-cab
force-pushed
the
export-D63798842
branch
from
0522869 to
3ca2606
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D63798842 |
Summary: Before we were using lists which meant `CompositeBackgroundDrawable` had a `LayerDrawable` of variable length. This meant that our layers were not consistent and made it hard to optimize `CompositeBackgroundDrawable` to not create a new instance every time we set a new Layer. With this change `CompositeBackgroundDrawable` has a consistent amount of layers which will allow us to more easily mutate it and land the optimization present on D63287222 Changelog: [Internal] Reviewed By: NickGerleman Differential Revision: D63798842
jorge-cab
force-pushed
the
export-D63798842
branch
from
3ca2606 to
085d738
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D63798842 |
jorge-cab
added a commit
to jorge-cab/react-native
that referenced
this pull request
Nov 19, 2024
Summary: Before we were using lists which meant `CompositeBackgroundDrawable` had a `LayerDrawable` of variable length. This meant that our layers were not consistent and made it hard to optimize `CompositeBackgroundDrawable` to not create a new instance every time we set a new Layer. With this change `CompositeBackgroundDrawable` has a consistent amount of layers which will allow us to more easily mutate it and land the optimization present on D63287222 Changelog: [Internal] Reviewed By: NickGerleman Differential Revision: D63798842
Contributor
|
This pull request has been merged in fd2ce35. |
Collaborator
|
This pull request was successfully merged by @jorge-cab in fd2ce35 When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Before we were using lists which meant
CompositeBackgroundDrawablehad aLayerDrawableof variable length.This meant that our layers were not consistent and made it hard to optimize
CompositeBackgroundDrawableto not create a new instance every time we set a new Layer.With this change
CompositeBackgroundDrawablehas a consistent amount of layers which will allow us to more easily mutate it and land the optimization present on D63287222Differential Revision: D63798842