Nullable borderRadius optimization on shadows and outline#46819
Closed
jorge-cab wants to merge 1 commit into
Closed
Nullable borderRadius optimization on shadows and outline#46819jorge-cab wants to merge 1 commit into
jorge-cab wants to merge 1 commit into
Conversation
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D63798853 |
jorge-cab
force-pushed
the
export-D63798853
branch
from
b2795c4 to
7c95498
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D63798853 |
jorge-cab
force-pushed
the
export-D63798853
branch
from
7c95498 to
2bc0dec
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D63798853 |
jorge-cab
force-pushed
the
export-D63798853
branch
from
2bc0dec to
78a00e4
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D63798853 |
jorge-cab
force-pushed
the
export-D63798853
branch
from
78a00e4 to
3cce515
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D63798853 |
jorge-cab
force-pushed
the
export-D63798853
branch
from
3cce515 to
3e8b52f
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D63798853 |
jorge-cab
force-pushed
the
export-D63798853
branch
from
3e8b52f to
caa9179
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D63798853 |
…6819) Summary: Just some preparation to implement the new `BackgroundDrawable` and `BorderDrawable`. This makes shadows and outline rely on `CompositeBackgroundDrawable` to set the state of `BorderRadiusStyle` and also makes them have a nullable borderRadius variable and initialize it only if we have it set saving a bit of overhead and performance Changelog: [Internal] Reviewed By: NickGerleman Differential Revision: D63798853
jorge-cab
force-pushed
the
export-D63798853
branch
from
caa9179 to
3c7d8f8
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D63798853 |
jorge-cab
added a commit
to jorge-cab/react-native
that referenced
this pull request
Oct 17, 2024
…acebook#46819) Summary: Just some preparation to implement the new `BackgroundDrawable` and `BorderDrawable`. This makes shadows and outline rely on `CompositeBackgroundDrawable` to set the state of `BorderRadiusStyle` and also makes them have a nullable borderRadius variable and initialize it only if we have it set saving a bit of overhead and performance Changelog: [Internal] Reviewed By: NickGerleman Differential Revision: D63798853
Contributor
|
This pull request has been merged in 02e4f3e. |
Collaborator
|
This pull request was successfully merged by @jorge-cab in 02e4f3e When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Just some preparation to implement the new
BackgroundDrawableandBorderDrawable.This makes shadows and outline rely on
CompositeBackgroundDrawableto set the state ofBorderRadiusStyleand also makes them have a nullable borderRadius variable and initialize it only if we have it set saving a bit of overhead and performanceChangelog: [Internal]
Differential Revision: D63798853