Back out "cache JNI calls to FabricUIManager::getColor"#46871
Closed
AlonsoPaulino wants to merge 1 commit into
Closed
Back out "cache JNI calls to FabricUIManager::getColor"#46871AlonsoPaulino wants to merge 1 commit into
AlonsoPaulino wants to merge 1 commit into
Conversation
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D64002346 |
AlonsoPaulino
force-pushed
the
export-D64002346
branch
from
c37900c to
5f76608
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D64002346 |
Collaborator
|
Summary: changelog: [internal] Original commit changeset: 748efce7f0b8 Original Phabricator Diff: D59859754 This is temporarily until we find an actual solution that can both cache the colors and also react to theme changes updating the colors value properly. Differential Revision: D64002346
AlonsoPaulino
force-pushed
the
export-D64002346
branch
from
5f76608 to
b6d0e00
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D64002346 |
Contributor
|
This pull request has been merged in aaf7a6a. |
Collaborator
|
This pull request was successfully merged by Alonso Paulino in aaf7a6a When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
changelog: [internal]
Original commit changeset: 748efce7f0b8
Original Phabricator Diff: D59859754
This is temporarily until we found an actual solution that can both cache the colors and also react to theme changes updating the colors value properly.