fix: override podspecs dependencies c++ version#46888
Closed
Titozzz wants to merge 1 commit into
Closed
Conversation
facebook-github-bot
added
CLA Signed
cipolleschi
approved these changes
Oct 8, 2024
Contributor
cipolleschi
left a comment
cipolleschi
left a comment
There was a problem hiding this comment.
Thanks @Titozzz for fixing this properly!
Contributor
|
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Contributor
|
@cipolleschi merged this pull request in d7a8aae. |
Collaborator
|
This pull request was successfully merged by @Titozzz in d7a8aae When will my fix make it into a release? | How to file a pick request? |
blakef
pushed a commit
that referenced
this pull request
Oct 15, 2024
Summary: Some dependencies would override C++ version like [this](https://github.com/mrousavy/react-native-vision-camera/blob/83abb0832a22b6b080f8412ed17b0992532b0eb2/VisionCamera.podspec#L36). We force it back to be the current version set by react-native so that we are sure projects are using the correct version [IOS] [FIXED] - Enforce we use the correct C++ version for all, even if dependency tries to set it Pull Request resolved: #46888 Test Plan: This can be test via https://github.com/Titozzz/cpp17bug Reviewed By: blakef Differential Revision: D64042099 Pulled By: cipolleschi fbshipit-source-id: c36dda0a718e52e19d53c3e9d895315141cb040c
Contributor
|
oh, sorry. This is my lib and it should set the pod target xcconfig, not the root project's xcconfig |
This was referenced Apr 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Some dependencies would override C++ version like this.
We force it back to be the current version set by react-native so that we are sure projects are using the correct version
Changelog:
[IOS] [FIXED] - Enforce we use the correct C++ version for all, even if dependency tries to set it
Test Plan:
This can be test via
https://github.com/Titozzz/cpp17bug