Add boxShadow support to BaseViewManager#46936
Closed
NickGerleman wants to merge 2 commits into
Closed
Conversation
…k#46934) Summary: BaseViewManagerDelegate is a handcrafted second source of truth, used specifically for codegen. The organization here has some problems, but this diff adds the props currently missing from it, so that these work correctly in generated view managers. Changelog: [Android][Fixed] - Add missing BaseViewManager props to BaseViewManagerDelegate Differential Revision: D64137615
Summary: Let's enable box-shadow everywhere! This should be safe, now that we assume any background mutating methods in BaseViewManager go through BackgroundStyleApplicator. `boxShadow` is also already in `BaseViewConfig` instead of configs for each native component (bc we were already planning to make this change). Changelog: [Android][Added] - Add boxShadow support to BaseViewManager Differential Revision: D64140841
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D64140841 |
Contributor
|
This pull request has been merged in b69a92e. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Let's enable box-shadow everywhere! This should be safe, now that we assume any background mutating methods in BaseViewManager go through BackgroundStyleApplicator.
boxShadowis also already inBaseViewConfiginstead of configs for each native component (bc we were already planning to make this change).Changelog:
[Android][Added] - Add boxShadow support to BaseViewManager
Differential Revision: D64140841