RNGP - Pass PROJECT_ROOT_DIR to CMake#46958
Closed
cortinico wants to merge 1 commit into
Closed
Conversation
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D64183641 |
Summary: This will make it easier to link against custom C++ TM which will most likely live inside ./shared or some other paths outside of ./android. CMake will have access to `PROJECT_ROOT_DIR` which points to ./android (the folder where the settings.gradle file exists). Changelog: [Internal] [Changed] - RNGP - Pass PROJECT_ROOT_DIR to CMake Differential Revision: D64183641
cortinico
force-pushed
the
export-D64183641
branch
from
9b06926 to
b160baa
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D64183641 |
cortinico
force-pushed
the
export-D64183641
branch
from
b160baa to
a900482
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D64183641 |
Contributor
|
This pull request has been merged in 2c45675. |
Collaborator
|
This pull request was successfully merged by @cortinico in 2c45675 When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
This will make it easier to link against custom C++ TM which will most likely live inside ./shared or
some other paths outside of ./android.
CMake will have access to
PROJECT_ROOT_DIRwhich points to ./android (the folder where the settings.gradle file exists).Changelog:
[Internal] [Changed] - RNGP - Pass PROJECT_ROOT_DIR to CMake
Differential Revision: D64183641