Swallow exceptions on draw, forward to onError#46964
Closed
Abbondanzo wants to merge 1 commit into
Closed
Conversation
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D64144596 |
Abbondanzo
force-pushed
the
export-D64144596
branch
from
9019e22 to
cc1985f
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D64144596 |
1 similar comment
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D64144596 |
Abbondanzo
force-pushed
the
export-D64144596
branch
from
cc1985f to
65a1b94
Compare
Summary: Pull Request resolved: facebook#46964 Graceful degradation is better than outright crashing. When rendering images that exceed Android's memory limits, React Native applications will fatally crash. This change intervenes by swallowing the exception that Android raises and forwards it to the `onError` handler. As a result, no image will be rendered instead of fatally crashing. Fresco already intervenes by default. It will raise a `PoolSizeViolationException` if the bitmap size exceeds memory limits set by the OS and applies a 2048 pixel maximum dimension to JPEG images, but it's still possible for these configuration limits to be removed and for images to fall just short of Fresco's memory limit. The exception is raised when we attempt to draw the bitmap, not when the bitmap is allocated in memory, so we must handle the exception here and not in Fresco. ## Changelog [Android][Fixed] - Apps will no longer fatally crash when trying to draw large images Reviewed By: tdn120 Differential Revision: D64144596
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D64144596 |
Abbondanzo
force-pushed
the
export-D64144596
branch
from
65a1b94 to
0e8d69e
Compare
Contributor
|
This pull request has been merged in 483b928. |
Collaborator
|
This pull request was successfully merged by @Abbondanzo in 483b928 When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Graceful degradation is better than outright crashing. When rendering images that exceed Android's memory limits, React Native applications will fatally crash. This change intervenes by swallowing the exception that Android raises and forwards it to the
onErrorhandler. As a result, no image will be rendered instead of fatally crashing.Fresco already intervenes by default. It will raise a
PoolSizeViolationExceptionif the bitmap size exceeds memory limits set by the OS and applies a 2048 pixel maximum dimension to JPEG images, but it's still possible for these configuration limits to be removed and for images to fall just short of Fresco's memory limit. The exception is raised when we attempt to draw the bitmap, not when the bitmap is allocated in memory, so we must handle the exception here and not in Fresco.Changelog
[Android][Fixed] - Apps will no longer fatally crash when trying to draw large images
Differential Revision: D64144596