Force bridgeless feature flags in RCTAppDelegate when bridgeless is enabled#46972
Closed
rubennorte wants to merge 1 commit into
Closed
Force bridgeless feature flags in RCTAppDelegate when bridgeless is enabled#46972rubennorte wants to merge 1 commit into
rubennorte wants to merge 1 commit into
Conversation
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D64234056 |
rubennorte
force-pushed
the
export-D64234056
branch
from
36a0a40 to
6a55dc3
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D64234056 |
rubennorte
force-pushed
the
export-D64234056
branch
from
6a55dc3 to
f57d5dc
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D64234056 |
rubennorte
force-pushed
the
export-D64234056
branch
from
f57d5dc to
1ccc8c9
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D64234056 |
…nabled (facebook#46972) Summary: Changelog: [internal] I'm unifying the feature flags for the new event loop (so it's enabled by default when bridgeless is enabled, unless a feature flag is explicitly set), and I realized that the feature flags for Bridgeless, Fabric and Turbo Modules aren't being set in iOS, causing my changes to be incorrect (as we're using bridgeless but the bridgeless flag is off). This forces the right flags when using bridgeless so the configuration is consistent. Reviewed By: rshest, cipolleschi Differential Revision: D64234056
rubennorte
force-pushed
the
export-D64234056
branch
from
1ccc8c9 to
9a1080b
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D64234056 |
Contributor
|
This pull request has been merged in 3ebf4f3. |
Collaborator
|
This pull request was successfully merged by @rubennorte in 3ebf4f3 When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog: [internal]
I'm unifying the feature flags for the new event loop (so it's enabled by default when bridgeless is enabled, unless a feature flag is explicitly set), and I realized that the feature flags for Bridgeless, Fabric and Turbo Modules aren't being set in iOS, causing my changes to be incorrect (as we're using bridgeless but the bridgeless flag is off).
This forces the right flags when using bridgeless so the configuration is consistent.
Differential Revision: D64234056