fix(iOS): Replace uses of CGColorRef with UIColor to avoid manual memory management v2#47019
Closed
joevilches wants to merge 1 commit into
Closed
fix(iOS): Replace uses of CGColorRef with UIColor to avoid manual memory management v2#47019joevilches wants to merge 1 commit into
CGColorRef with UIColor to avoid manual memory management v2#47019joevilches wants to merge 1 commit into
Conversation
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D64201626 |
Contributor
Author
…emory management v2 (facebook#47019) Summary: NOTE: This code is largely the same as facebook#46847, I am merely fixing some internal issues The original diff (D63989547) was backed out because it was causing some crashes related to some internal code that had to be changed. That code did not necessarily need to be changed - we could have just left the `RCTCreateCGColorRefFromSharedColor` function and not touched the internal code - which is what I am going to do here Changelog: [Internal] Differential Revision: D64201626
joevilches
force-pushed
the
export-D64201626
branch
from
1811023 to
ab8d453
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D64201626 |
Contributor
|
TIL, Even for changes on main, remove methods in a separate change :D |
Contributor
|
This pull request has been merged in dd1aea5. |
Collaborator
|
This pull request was successfully merged by @joevilches in dd1aea5 When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
The original diff (D63989547) was backed out because it was causing some crashes related to some internal code that had to be changed. That code did not necessarily need to be changed - we could have just left the
RCTCreateCGColorRefFromSharedColorfunction and not touched the internal code - which is what I am going to do hereChangelog: [Internal]
Differential Revision: D64201626