Codegen fails with Local Module#47027
Closed
cipolleschi wants to merge 1 commit into
Closed
Conversation
facebook-github-bot
added
CLA Signed
cipolleschi
force-pushed
the
export-D64242713
branch
from
936518c to
2a9137c
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D64242713 |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D64242713 |
Summary: While I was writing the documentation for extracting a module in a library, I realized that Codegen ignored the local node modules. The reason is that `require.resolve` fails to resolve a local path. ## Changelog [General][Fixed] - Make Codegen work with local modules Reviewed By: cortinico Differential Revision: D64242713
cipolleschi
force-pushed
the
export-D64242713
branch
from
2a9137c to
9813155
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D64242713 |
Contributor
|
This pull request has been merged in 7b6e8e7. |
Collaborator
|
This pull request was successfully merged by @cipolleschi in 7b6e8e7 When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
While I was writing the documentation for extracting a module in a library, I realized that Codegen ignored the local node modules.
The reason is that
require.resolvefails to resolve a local path.Changelog
[General][Fixed] - Make Codegen work with local modules
Reviewed By: cortinico
Differential Revision: D64242713