copy by value in RunLoopObserver ctor#47051
Closed
sammy-SC wants to merge 2 commits into
Closed
Conversation
Summary: changelog: [internal] - Rename SchedulerToolbox::asynchronousEventBeatFactory to SchedulerToolbox::eventBeatFactory. There is only one event beach, no need to distinguish between sync and async. - Remove typealias EventBeat::SharedOwnerBox and pass by value instead of const&. # Goal of this stack: Centralise event beat logic into EventBeat class inside react-native-github. Subclasses should only override `EventBeat::request` and `EventBeat::induce`. Differential Revision: D64291288
Summary: changelog: [internal] copy weak owner instead of using const&. const& is wrong here and hides important information because weak owner is always copied into ivat. Goal of this stack: Centralise event beat logic into EventBeat class inside react-native-github. Subclasses should only override EventBeat::request and EventBeat::induce. Differential Revision: D64291515
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D64291515 |
sammy-SC
added a commit
to sammy-SC/react-native
that referenced
this pull request
Oct 16, 2024
Summary: changelog: [internal] copy weak owner instead of using const&. const& is wrong here and hides important information because weak owner is always copied into ivat. Goal of this stack: Centralise event beat logic into EventBeat class inside react-native-github. Subclasses should only override EventBeat::request and EventBeat::induce. Differential Revision: D64291515
Contributor
|
This pull request has been merged in b1ec76e. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
changelog: [internal]
copy weak owner instead of using const&. const& is wrong here and hides important information because weak owner is always copied into ivat.
Goal of this stack:
Centralise event beat logic into EventBeat class inside react-native-github. Subclasses should only override EventBeat::request and EventBeat::induce.
Differential Revision: D64291515