delete EventBeat's copy ctor and remove default implementation for induce#47057
Closed
sammy-SC wants to merge 5 commits into
Closed
delete EventBeat's copy ctor and remove default implementation for induce#47057sammy-SC wants to merge 5 commits into
sammy-SC wants to merge 5 commits into
Conversation
Differential Revision: D64291288
Differential Revision: D64291515
Differential Revision: D64291401
Differential Revision: D64301829
…duce Summary: changelog: [internal] EventBeat should never be copied. Make that explicit. EventBeat::induce must never be empty, remove the default implementation. # Goal of this stack: Centralise event beat logic into EventBeat class inside react-native-github. Subclasses should only override EventBeat::request and EventBeat::induce. Differential Revision: D64291845
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D64291845 |
Contributor
|
This pull request has been merged in a72510d. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
changelog: [internal]
EventBeat should never be copied. Make that explicit.
EventBeat::induce must never be empty, remove the default implementation.
Goal of this stack:
Centralise event beat logic into EventBeat class inside react-native-github. Subclasses should only override EventBeat::request and EventBeat::induce.
Differential Revision: D64291845