Migrate MainReactPackage to Kotlin#47070
Closed
cortinico wants to merge 1 commit into
Closed
Conversation
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D64479418 |
Summary: Pull Request resolved: facebook#47070 For the sake of Stable API, I'd like to get this class converted to Kotlin The class is becoming `final` so could be breaking for some users if they subclass `MainReactPackage` which I believe this should not be a valid usage of this API. Changelog: [Android] [Changed] - Migrate MainReactPackage to Kotlin (and make it final) Reviewed By: tdn120 Differential Revision: D64479418
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D64479418 |
cortinico
force-pushed
the
export-D64479418
branch
from
b4467ed to
b393135
Compare
Contributor
|
This pull request has been merged in 7bbac8e. |
Collaborator
|
This pull request was successfully merged by @cortinico in 7bbac8e When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
For the sake of Stable API, I'd like to get this class converted to Kotlin
The class is becoming
finalso could be breaking for some users if they subclassMainReactPackagewhich I believe this should not be a valid usage of this API.Changelog:
[Android] [Changed] - Migrate MainReactPackage to Kotlin (and make it final)
Differential Revision: D64479418