add appId as a standalone field#47098
Closed
EdmondChuiHW wants to merge 1 commit into
Closed
Conversation
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D64547367 |
Summary: Changelog: [Internal] D63329456 updated the `description` field to be human-readable. Unfortunately, InspectorProxy relies on this field to compare the incoming `/open-debugger` calls. hoxyq discovered the symptom of Fusebox failing to launch with `No compatible apps connected. React Native DevTools can only be used with the Hermes engine.` in Metro Reviewed By: hoxyq Differential Revision: D64547367
e3293af to
7de5268
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D64547367 |
EdmondChuiHW
added a commit
to EdmondChuiHW/react-native
that referenced
this pull request
Oct 17, 2024
Summary: Changelog: [Internal] D63329456 updated the `description` field to be human-readable. Unfortunately, InspectorProxy relies on this field to compare the incoming `/open-debugger` calls. hoxyq discovered the symptom of Fusebox failing to launch with `No compatible apps connected. React Native DevTools can only be used with the Hermes engine.` in Metro Reviewed By: hoxyq Differential Revision: D64547367
Contributor
|
This pull request has been merged in 0d591d9. |
Collaborator
|
This pull request was successfully merged by @EdmondChuiHW in 0d591d9 When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog: [Internal]
D63329456 updated the
descriptionfield to be human-readable.Unfortunately, InspectorProxy relies on this field to compare the incoming
/open-debuggercalls.hoxyq discovered the symptom of Fusebox failing to launch with
No compatible apps connected. React Native DevTools can only be used with the Hermes engine.in MetroDifferential Revision: D64547367