Fix incorrect type being passed to NativePerformance.mark#47102
Closed
rubennorte wants to merge 1 commit into
Closed
Fix incorrect type being passed to NativePerformance.mark#47102rubennorte wants to merge 1 commit into
rubennorte wants to merge 1 commit into
Conversation
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D64557467 |
rubennorte
force-pushed
the
export-D64557467
branch
from
39b4cdd to
3a24226
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D64557467 |
…7102) Summary: Changelog: [internal] In D64466057 / facebook@32f7b3b we accidentally modified the API of `NativePerformance.mark` (which we wanted to preserve and move the changes to `NativePerformance.markWithResult` after some iteration) to make `startTime` optional, which isn't compatible with the previous native API. This fixes the issue by reverting the type back to being required and always passing it from the JS API. Differential Revision: D64557467
rubennorte
force-pushed
the
export-D64557467
branch
from
3a24226 to
e5f6a71
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D64557467 |
Contributor
|
This pull request has been merged in 14bbb87. |
Collaborator
|
This pull request was successfully merged by @rubennorte in 14bbb87 When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog: [internal]
In D64466057 / 32f7b3b we accidentally modified the API of
NativePerformance.mark(which we wanted to preserve and move the changes toNativePerformance.markWithResultafter some iteration) to makestartTimeoptional. This change isn't OTA safe and no automated systems caught this problem.This fixes the issue by reverting the type back to being required and always passing it from the JS API.
Differential Revision: D64557467