Skip to content

delete typealias RunLoopObserver::Unique #47117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sammy-SC wants to merge 1 commit into from
Closed

delete typealias RunLoopObserver::Unique #47117

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/react-native/React/Fabric/AppleEventBeat.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ namespace facebook::react {

AppleEventBeat::AppleEventBeat(
std::shared_ptr<OwnerBox> ownerBox,
RunLoopObserver::Unique uiRunLoopObserver,
std::unique_ptr<const RunLoopObserver> uiRunLoopObserver,
RuntimeExecutor runtimeExecutor)
: EventBeat(std::move(ownerBox), std::move(runtimeExecutor)),
uiRunLoopObserver_(std::move(uiRunLoopObserver)) {
Expand Down
4 changes: 2 additions & 2 deletions packages/react-native/React/Fabric/AppleEventBeat.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ class AppleEventBeat : public EventBeat, public RunLoopObserver::Delegate {
public:
AppleEventBeat(
std::shared_ptr<OwnerBox> ownerBox,
RunLoopObserver::Unique uiRunLoopObserver,
std::unique_ptr<const RunLoopObserver> uiRunLoopObserver,
RuntimeExecutor runtimeExecutor);

#pragma mark - RunLoopObserver::Delegate
Expand All @@ -32,7 +32,7 @@ class AppleEventBeat : public EventBeat, public RunLoopObserver::Delegate {
RunLoopObserver::Activity activity) const noexcept override;

private:
RunLoopObserver::Unique uiRunLoopObserver_;
std::unique_ptr<const RunLoopObserver> uiRunLoopObserver_;
};

} // namespace facebook::react
2 changes: 1 addition & 1 deletion packages/react-native/React/Fabric/RCTScheduler.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@ @implementation RCTScheduler {
std::shared_ptr<LayoutAnimationDriver> _animationDriver;
std::unique_ptr<SchedulerDelegateProxy> _delegateProxy;
std::shared_ptr<LayoutAnimationDelegateProxy> _layoutAnimationDelegateProxy;
RunLoopObserver::Unique _uiRunLoopObserver;
std::unique_ptr<const PlatformRunLoopObserver> _uiRunLoopObserver;
}

- (instancetype)initWithToolbox:(SchedulerToolbox)toolbox
Expand Down
2 changes: 0 additions & 2 deletions packages/react-native/ReactCommon/react/utils/RunLoopObserver.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,6 @@ namespace facebook::react {
*/
class RunLoopObserver {
public:
using Unique = std::unique_ptr<const RunLoopObserver>;

/*
* The concept of an owner.
* A run loop observer normally observes a run loop running on a different
Expand Down